bowenliang123 commented on code in PR #4221:
URL: https://github.com/apache/kyuubi/pull/4221#discussion_r1093983809
##########
kyuubi-rest-client/src/main/java/org/apache/kyuubi/client/IRestClient.java:
##########
@@ -27,6 +28,8 @@ public interface IRestClient extends AutoCloseable {
<T> T post(String path, String body, Class<T> type, String authHeader);
+ <T> T post(String path, HttpEntity requestEntity, Class<T> type, String
authHeader);
Review Comment:
But a map of key-to-file is not enough to represent the whole request entity.
In this client request,
- entity body (in media type of `multipart-formdata`)
- subpart1 (key, string value, media type of `application-json`,
explicitly required)
- subpart2 (key, File, media type of file itself)
- subpart3 (key, value, other media type) and etc.
And also the charsets.
`HttpEntity` wraps all the details and that's the reason it's used as input
class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
