pan3793 commented on code in PR #4242:
URL: https://github.com/apache/kyuubi/pull/4242#discussion_r1098250997
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -371,7 +371,7 @@ object KyuubiConf {
object FrontendProtocols extends Enumeration {
type FrontendProtocol = Value
- val THRIFT_BINARY, THRIFT_HTTP, REST, MYSQL, TRINO = Value
+ val THRIFT_BINARY, THRIFT_BINARY_SSL, THRIFT_HTTP, REST, MYSQL, TRINO =
Value
Review Comment:
I think the idea here is:
1. THRIFT_BINARY, THRIFT_BINARY_SSL should be like HTTP, HTTPS eventually,
there are discrete and can be enabled at the same time.
2. currently we keep SSL option of THRIFT_BINARY for compatibility, the
deprecating message has been added and this feature will be removed in the 2.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
