iodone commented on code in PR #4232:
URL: https://github.com/apache/kyuubi/pull/4232#discussion_r1099763807


##########
kyuubi-server/pom.xml:
##########
@@ -221,6 +221,16 @@
             <artifactId>jersey-media-multipart</artifactId>
         </dependency>
 
+        <dependency>
+            <groupId>com.fasterxml.jackson.core</groupId>
+            <artifactId>jackson-databind</artifactId>
+        </dependency>
+
+        <dependency>
+            <groupId>com.fasterxml.jackson.datatype</groupId>
+            <artifactId>jackson-datatype-jdk8</artifactId>

Review Comment:
   Yes, the data type we currently declare in the Trino HTTP req/res DTO are of 
java8 DataType. [Java 8 
Datatypes](https://github.com/FasterXML/jackson-modules-java8/blob/2.15/datatypes):
 support for other new Java 8 datatypes outside of date/time: most notably 
Optional, OptionalLong, OptionalDouble.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to