xuefeimiaoao commented on code in PR #4246:
URL: https://github.com/apache/kyuubi/pull/4246#discussion_r1101245449
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/schema/SchemaHelper.scala:
##########
@@ -64,7 +82,7 @@ object SchemaHelper {
case _: ArrayType => TTypeId.ARRAY_TYPE
case _: MapType => TTypeId.MAP_TYPE
case _: StructType => TTypeId.STRUCT_TYPE
- // TODO: it is private now, case udt: UserDefinedType =>
TTypeId.USER_DEFINED_TYPE
+ case dt: DateType if isUserDefinedType(dt) => TTypeId.USER_DEFINED_TYPE
Review Comment:
Thanks, i will revise the dataType. Besides, UserDefinedType is still
private in spark 3.1, so we may avoid importing this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
