bowenliang123 commented on code in PR #4168:
URL: https://github.com/apache/kyuubi/pull/4168#discussion_r1103911826
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/serde/CommandSpec.scala:
##########
@@ -108,3 +109,19 @@ case class ScanSpec(
}
}
}
+
+case class FunctionSpec(classname: String, functionDescs: Seq[FunctionDesc])
extends CommandSpec {
+ override def opType: String = OperationType.QUERY.toString
+
+ def functions: (Expression) => Seq[Function] = (expr) => {
Review Comment:
After a second thought, I would prefer to extract the functions by adding
this method to the ScanSpec without bringing a new Spec in this PR. ScanSpec is
solely responsible for resource extracting from logical plans and should be
able to cover this scenario.
also cc @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
