pan3793 commented on code in PR #3374:
URL: https://github.com/apache/kyuubi/pull/3374#discussion_r1107983865
##########
docs/deployment/settings.md:
##########
@@ -456,6 +456,13 @@ kyuubi.session.engine.startup.error.max.size|8192|During
engine bootstrapping, i
kyuubi.session.engine.startup.maxLogLines|10|The maximum number of engine log
lines when errors occur during engine startup phase. Note that this max lines
is for client-side to help track engine startup issue.|int|1.4.0
kyuubi.session.engine.startup.waitCompletion|true|Whether to wait for
completion after engine starts. If false, the startup process will be destroyed
after the engine is started. Note that only use it when the driver is not
running locally, such as yarn-cluster mode; Otherwise, the engine will be
killed.|boolean|1.5.0
kyuubi.session.engine.trino.connection.catalog|<undefined>|The default
catalog that trino engine will connect to|string|1.5.0
+kyuubi.session.engine.trino.connection.keystore.password|<undefined>|The
keystore password used for connecting to trino cluster|string|1.7.0
Review Comment:
We should update the existing configurations to make them consistent, and
maybe we can remove `connection.` as well?
```
buildConf("kyuubi.engine.trino.url")
.version("1.7.0")
.withAlternative("kyuubi.session.engine.trino.connection.url")
.stringConf
.createOptional
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
