Yikf commented on code in PR #4369:
URL: https://github.com/apache/kyuubi/pull/4369#discussion_r1111171375
##########
.github/workflows/master.yml:
##########
@@ -434,7 +434,6 @@ jobs:
run: >-
./build/mvn ${MVN_OPT} clean install
-Pflink-provided,hive-provided
- -Pspark-3.2
Review Comment:
~It's better to specify `spark-3.3`.~
Apache Spark version of the kubernetes-it is currently definitive and
unique, It should be consist with
[kubernetes-it](https://github.com/apache/kyuubi/blob/master/integration-tests/kyuubi-kubernetes-it/src/test/scala/org/apache/kyuubi/kubernetes/test/spark/SparkOnKubernetesTestsSuite.scala#L48)
to to prevent serialization problems in k8s-client mode.
~Before we finish this
[TODO](https://github.com/apache/kyuubi/blob/master/integration-tests/kyuubi-kubernetes-it/src/test/scala/org/apache/kyuubi/kubernetes/test/spark/SparkOnKubernetesTestsSuite.scala#L45),
it's a good idea to specify a profile in case we change the default spark
version of kyuubi and spark docker doesn't have mirroring issues with that
version.~
Edit:
It seems better to keep
https://github.com/apache/kyuubi/blob/master/integration-tests/kyuubi-kubernetes-it/src/test/scala/org/apache/kyuubi/kubernetes/test/spark/SparkOnKubernetesTestsSuite.scala#L48
consistent with the default spark version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
