bowenliang123 commented on code in PR #4372:
URL: https://github.com/apache/kyuubi/pull/4372#discussion_r1111542061
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/OperationsResource.scala:
##########
@@ -183,19 +183,47 @@ private[v1] class OperationsResource extends
ApiRequestContext with Logging {
i.getSetField.name(),
i.getSetField match {
case TColumnValue._Fields.STRING_VAL =>
- i.getStringVal.getFieldValue(TStringValue._Fields.VALUE)
+ if (i.getStringVal.isSetValue) {
Review Comment:
A possible risk is that `getStringVal` on the unset field will throw
RuntimeException here.
Is that better with `i.isSetStringVal` for the case condition ? And make
null as default return.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
