thomasg19930417 commented on PR #4354: URL: https://github.com/apache/kyuubi/pull/4354#issuecomment-1436802818
> @thomasg19930417 Can you show more detailed concerns and add more description to this PR, including and not limited to the purpose, the changes, the config it provides, the range this PR covering and the consequence and sequence of them. > > As for me, I would suggest, > > 1. provide a config to decide the source(s) type of initial SQLs, rather than just chaining them in preset oreder > 2. please clarify the source type you suggested to support, local file, any remote filesystem or else. HDFS from the issue description might not be urgent for first choice to introduced. > 3. the limitation to the path(s), either one or more paths supported, any other limit to this. > 4. what's the init sql file meant or treated to non-SQL language type, as Scala, Python and etc also supported now in Kyuubi. > @thomasg19930417 Can you show more detailed concerns and add more description to this PR, including and not limited to the purpose, the changes, the config it provides, the range this PR covering and the consequence and sequence of them. > > As for me, I would suggest, > > 1. provide a config to decide the source(s) type of initial SQLs, rather than just chaining them in preset oreder > 2. please clarify the source type you suggested to support, local file, any remote filesystem or else. HDFS from the issue description might not be urgent for first choice to introduced. > 3. the limitation to the path(s), either one or more paths supported, any other limit to this. > 4. what's the init sql file meant or treated to non-SQL language type, as Scala, Python and etc also supported now in Kyuubi. At present, initialization sql is controlled by two parameters, kyuubi.engine.initialize.sql and kyuubi.engine.session.initialize.sql. These two configurations are configured in kyuubi-defult. Assuming that there are many initial udf functions to be created, I think it would be better to configure them in a separate file, Therefore, I added a parameter kyuubi.engine.initialize.sql.type here to control whether to initialize or read the initialized sql from the file About initSql, I think the current implementation only supports sql. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
