bowenliang123 commented on code in PR #4358:
URL: https://github.com/apache/kyuubi/pull/4358#discussion_r1112562192
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/util/RuleEliminateMarker.scala:
##########
@@ -22,6 +22,9 @@ import org.apache.spark.sql.catalyst.rules.Rule
class RuleEliminateMarker extends Rule[LogicalPlan] {
override def apply(plan: LogicalPlan): LogicalPlan = {
- plan.transformUp { case rf: RowFilterAndDataMaskingMarker => rf.child }
+ plan.transformUp {
+ case rf: DataMaskingMarker => rf.child
+ case rf: RowFilterMarker => rf.child
Review Comment:
duplicated `rf` is more like the short form of `rowfilter` and not suitable
for both DataMaskingMarker and RowFilterMarker. And in suggested style we could
just skip naming it .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
