pan3793 commented on code in PR #4144:
URL: https://github.com/apache/kyuubi/pull/4144#discussion_r1112957149


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiReservedKeys.scala:
##########
@@ -24,6 +24,7 @@ object KyuubiReservedKeys {
   final val KYUUBI_SESSION_SIGN_PUBLICKEY = "kyuubi.session.sign.publickey"
   final val KYUUBI_SESSION_USER_SIGN = "kyuubi.session.user.sign"
   final val KYUUBI_SESSION_REAL_USER_KEY = "kyuubi.session.real.user"
+  final val KYUUBI_SESSION_BATCH_RESOURCE_UPLOADED_KEY = 
"kyuubi.session.batch.resource.uploaded"

Review Comment:
   Should it be  `kyuubi.batch.session` instead of `kyuubi.session.batch`? As 
we already have `kyuubi.batch.session.idle.timeout`, they should be consistent.
   
   cc @bowenliang123 @turboFei  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org

Reply via email to