turboFei commented on code in PR #4395:
URL: https://github.com/apache/kyuubi/pull/4395#discussion_r1114029845
##########
docs/deployment/settings.md:
##########
@@ -455,6 +455,7 @@ You can configure the Kyuubi properties in
`$KYUUBI_HOME/conf/kyuubi-defaults.co
| kyuubi.server.batch.limit.connections.per.user | <undefined>
| Maximum kyuubi server batch connections per user. Any user exceeding this
limit will not be allowed to connect.
| int | 1.7.0 |
| kyuubi.server.batch.limit.connections.per.user.ipaddress | <undefined>
| Maximum kyuubi server batch connections per user:ipaddress combination. Any
user-ipaddress exceeding this limit will not be allowed to connect.
| int | 1.7.0 |
| kyuubi.server.info.provider | ENGINE
| The server information provider name, some clients may rely on this
information to check the server compatibilities and functionalities.
<li>SERVER: Return Kyuubi server information.</li> <li>ENGINE: Return Kyuubi
engine information.</li> | string | 1.6.1 |
+| kyuubi.server.limit.client.fetch.max.rows | 5000
| Max rows limit for getting result row set operation. If the max rows
specified by client-side is larger than the limit, request will fail directly.
| int | 1.7.0 |
Review Comment:
```
kyuubi.server.limit.connections.per.user.ipaddress
kyuubi.server.batch.limit.connections.per.user.ipaddress
kyuubi.server.limit.client.fetch.max.rows
```
should we rename the config
`kyuubi.server.batch.limit.connections.per.user.ipaddress` to
`kyuubi.server.limit.batch.connections.per.user.ipaddress` ? @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
