pan3793 commented on code in PR #4397:
URL: https://github.com/apache/kyuubi/pull/4397#discussion_r1114506465


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/http/authentication/AuthenticationFilter.scala:
##########
@@ -79,7 +79,6 @@ class AuthenticationFilter(conf: KyuubiConf) extends Filter 
with Logging {
 
   override def init(filterConfig: FilterConfig): Unit = {
     initAuthHandlers()
-    super.init(filterConfig)

Review Comment:
   To suppress the follow exception.
   ```
   java.lang.AbstractMethodError: 
javax.servlet.Filter.init(Ljavax/servlet/FilterConfig;)V
        at 
org.apache.kyuubi.server.http.authentication.AuthenticationFilter.init(AuthenticationFilter.scala:82)
 ~[kyuubi-server_2.12-1.8.0-SNAPSHOT.jar:1.8.0-SNAPSHOT]
        at 
org.eclipse.jetty.servlet.FilterHolder.initialize(FilterHolder.java:140) 
~[jetty-servlet-9.4.50.v20221201.jar:9.4.50.v20221201]
        at 
org.eclipse.jetty.servlet.ServletHandler.lambda$initialize$0(ServletHandler.java:750)
 ~[jetty-servlet-9.4.50.v20221201.jar:9.4.50.v20221201]
        at 
java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948) 
~[?:1.8.0_332]
        at 
java.util.stream.Streams$ConcatSpliterator.forEachRemaining(Streams.java:742) 
~[?:1.8.0_332]
        at 
java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:647) 
~[?:1.8.0_332]
        at 
org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:774) 
~[jetty-servlet-9.4.50.v20221201.jar:9.4.50.v20221201]
        at 
org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:379)
 ~[jetty-servlet-9.4.50.v20221201.jar:9.4.50.v20221201]
        at 
org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:916)
 ~[jetty-server-9.4.50.v20221201.jar:9.4.50.v20221201]
        at 
org.eclipse.jetty.servlet.ServletContextHandler.doStart(ServletContextHandler.java:288)
 ~[jetty-servlet-9.4.50.v20221201.jar:9.4.50.v20221201]
        at 
org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73)
 ~[jetty-util-9.4.50.v20221201.jar:9.4.50.v20221201]
        at 
org.apache.kyuubi.server.http.authentication.KyuubiHttpAuthenticationFactory$HttpHandlerWrapperFactory$$anon$1.doStart(KyuubiHttpAuthenticationFactory.scala:89)
 ~[kyuubi-server_2.12-1.8.0-SNAPSHOT.jar:1.8.0-SNAPSHOT]
        at 
org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73)
 ~[jetty-util-9.4.50.v20221201.jar:9.4.50.v20221201]
        at 
org.apache.kyuubi.server.ui.JettyServer.addHandler(JettyServer.scala:56) 
~[kyuubi-server_2.12-1.8.0-SNAPSHOT.jar:1.8.0-SNAPSHOT]
        at 
org.apache.kyuubi.server.KyuubiRestFrontendService.startInternal(KyuubiRestFrontendService.scala:88)
 ~[kyuubi-server_2.12-1.8.0-SNAPSHOT.jar:1.8.0-SNAPSHOT]
        at 
org.apache.kyuubi.server.KyuubiRestFrontendService.start(KyuubiRestFrontendService.scala:170)
 ~[kyuubi-server_2.12-1.8.0-SNAPSHOT.jar:1.8.0-SNAPSHOT]
        at 
org.apache.kyuubi.service.CompositeService.$anonfun$start$1(CompositeService.scala:47)
 ~[kyuubi-common_2.12-1.8.0-SNAPSHOT.jar:1.8.0-SNAPSHOT]
        at 
org.apache.kyuubi.service.CompositeService.$anonfun$start$1$adapted(CompositeService.scala:45)
 ~[kyuubi-common_2.12-1.8.0-SNAPSHOT.jar:1.8.0-SNAPSHOT]
        at 
scala.collection.mutable.ResizableArray.foreach(ResizableArray.scala:62) 
~[scala-library-2.12.17.jar:?]
        at 
scala.collection.mutable.ResizableArray.foreach$(ResizableArray.scala:55) 
~[scala-library-2.12.17.jar:?]
        at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:49) 
~[scala-library-2.12.17.jar:?]
        at 
org.apache.kyuubi.service.CompositeService.start(CompositeService.scala:45) 
~[kyuubi-common_2.12-1.8.0-SNAPSHOT.jar:1.8.0-SNAPSHOT]
        at org.apache.kyuubi.service.Serverable.start(Serverable.scala:51) 
~[kyuubi-common_2.12-1.8.0-SNAPSHOT.jar:1.8.0-SNAPSHOT]
        at org.apache.kyuubi.server.KyuubiServer.start(KyuubiServer.scala:182) 
~[kyuubi-server_2.12-1.8.0-SNAPSHOT.jar:1.8.0-SNAPSHOT]
        at 
org.apache.kyuubi.server.KyuubiServer$.startServer(KyuubiServer.scala:67) 
~[kyuubi-server_2.12-1.8.0-SNAPSHOT.jar:1.8.0-SNAPSHOT]
        at org.apache.kyuubi.server.KyuubiServer$.main(KyuubiServer.scala:99) 
~[kyuubi-server_2.12-1.8.0-SNAPSHOT.jar:1.8.0-SNAPSHOT]
        at org.apache.kyuubi.server.KyuubiServer.main(KyuubiServer.scala) 
~[kyuubi-server_2.12-1.8.0-SNAPSHOT.jar:1.8.0-SNAPSHOT]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to