pan3793 commented on code in PR #4381:
URL: https://github.com/apache/kyuubi/pull/4381#discussion_r1116458259
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/Logging.scala:
##########
@@ -117,16 +116,16 @@ object Logging {
// This distinguishes the log4j 1.2 binding, currently
// org.slf4j.impl.Log4jLoggerFactory, from the log4j 2.0 binding, currently
// org.apache.logging.slf4j.Log4jLoggerFactory
- val binderClass = StaticLoggerBinder.getSingleton.getLoggerFactoryClassStr
- "org.slf4j.impl.Log4jLoggerFactory".equals(binderClass)
+ "org.slf4j.impl.Log4jLoggerFactory"
+ .equals(LoggerFactory.getILoggerFactory.getClass.getName)
Review Comment:
we can make a separating PR for master/1.7 if it's a valid fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
