turboFei commented on code in PR #4405:
URL: https://github.com/apache/kyuubi/pull/4405#discussion_r1117842280


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -2429,6 +2429,16 @@ object KyuubiConf {
       .timeConf
       .createWithDefaultString("PT30M")
 
+  val SERVER_ADMIN_USERS: ConfigEntry[Seq[String]] =
+    buildConf("kyuubi.server.admin.users")
+      .doc("Comma-separated list of Kyuubi service admin users. " +
+        "We use this config to grant admin permission to any service 
accounts.")
+      .version("1.8.0")
+      .serverOnly
+      .stringConf
+      .toSequence()
+      .createWithDefault(Seq.empty)

Review Comment:
   nit: createWithDefault(Nil)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to