pan3793 commented on code in PR #4415:
URL: https://github.com/apache/kyuubi/pull/4415#discussion_r1118046522
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/ExecuteStatement.scala:
##########
@@ -39,13 +41,18 @@ class ExecuteStatement(
override val statement: String,
override val shouldRunAsync: Boolean,
queryTimeout: Long,
- incrementalCollect: Boolean)
+ incrementalCollect: Boolean,
+ opHandleOption: Option[OperationHandle])
extends SparkOperation(session) with Logging {
+ override protected val handle: OperationHandle =
opHandleOption.getOrElse(OperationHandle())
+
private val operationLog: OperationLog =
OperationLog.createOperationLog(session, getHandle)
override def getOperationLog: Option[OperationLog] = Option(operationLog)
override protected def supportProgress: Boolean = true
+ EventBus.post(SparkOperationEvent(this))
Review Comment:
it's quite tricky, we'd better refactor this to avoid confusing developers,
if not easy, add comments to explain what happened as least.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
