turboFei commented on code in PR #4459:
URL: https://github.com/apache/kyuubi/pull/4459#discussion_r1126307108
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkTBinaryFrontendService.scala:
##########
@@ -94,7 +94,13 @@ class SparkTBinaryFrontendService(
}
override def attributes: Map[String, String] = {
- Map(KYUUBI_ENGINE_ID -> KyuubiSparkUtil.engineId)
+ Map(
+ KYUUBI_ENGINE_ID -> KyuubiSparkUtil.engineId,
+ // TODO Support Spark Web UI Enabled SSL
+ KYUUBI_ENGINE_URL -> (sc.uiWebUrl match {
Review Comment:
you can add a internal config for the config keys list.
Such as `spark.driver.memory,spark.executor.memory`.
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkTBinaryFrontendService.scala:
##########
@@ -94,7 +94,13 @@ class SparkTBinaryFrontendService(
}
override def attributes: Map[String, String] = {
- Map(KYUUBI_ENGINE_ID -> KyuubiSparkUtil.engineId)
+ Map(
+ KYUUBI_ENGINE_ID -> KyuubiSparkUtil.engineId,
+ // TODO Support Spark Web UI Enabled SSL
+ KYUUBI_ENGINE_URL -> (sc.uiWebUrl match {
Review Comment:
you can add an internal config for the config keys list.
Such as `spark.driver.memory,spark.executor.memory`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
