turboFei commented on code in PR #4545:
URL: https://github.com/apache/kyuubi/pull/4545#discussion_r1142010906
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/session/SparkSQLSessionManager.scala:
##########
@@ -157,6 +157,10 @@ class SparkSQLSessionManager private (name: String, spark:
SparkSession)
}
override def closeSession(sessionHandle: SessionHandle): Unit = {
+ val closeGracefully = conf.get(ENGINE_SPARK_SESSION_CLOSE_GRACEFULLY)
Review Comment:
+1, we also need to do not close engine operation in kyuubi gateway side.
(close kyuubi gateway operation only, because now when closing kyuubi
gateway session, it will close the kyuubi gateway operations, and the
KyuubiOperation:close will close the remote engine operation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
