turboFei commented on code in PR #4545:
URL: https://github.com/apache/kyuubi/pull/4545#discussion_r1144093783
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/SparkSQLOperationManager.scala:
##########
@@ -27,7 +27,7 @@ import
org.apache.kyuubi.config.KyuubiReservedKeys.KYUUBI_OPERATION_HANDLE_KEY
import org.apache.kyuubi.engine.spark.repl.KyuubiSparkILoop
import org.apache.kyuubi.engine.spark.session.SparkSessionImpl
import org.apache.kyuubi.engine.spark.shim.SparkCatalogShim
-import org.apache.kyuubi.operation.{NoneMode, Operation, OperationHandle,
OperationManager, PlanOnlyMode}
+import org.apache.kyuubi.operation._
import org.apache.kyuubi.session.{Session, SessionHandle}
Review Comment:
Need to revert this
##########
docs/deployment/settings.md:
##########
@@ -372,6 +372,7 @@ You can configure the Kyuubi properties in
`$KYUUBI_HOME/conf/kyuubi-defaults.co
| Key | Default
|
Meaning
| Type | Since |
|------------------------------------------------------|-------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|----------|-------|
| kyuubi.session.check.interval | PT5M
| The check interval for session timeout.
| duration | 1.0.0 |
+| kyuubi.session.close.on.disconnect | true
| Session will be closed when connection is closed. Set this to false to have
session outlive its parent connection.
| boolean | 1.8.0 |
Review Comment:
For the description，'closed' is not accurate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
