Yikf commented on code in PR #4621:
URL: https://github.com/apache/kyuubi/pull/4621#discussion_r1149971003
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala:
##########
@@ -173,6 +175,10 @@ private[v1] class AdminResource extends ApiRequestContext
with Logging {
val usersSet = users.split(",").toSet
operations = operations.filter(operation =>
usersSet.contains(operation.getSession.user))
}
+ if (StringUtils.isNotBlank(sessionHandle)) {
Review Comment:
Agree with @pan3793 , we can refactor this method to improve performance.
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala:
##########
@@ -160,7 +160,9 @@ private[v1] class AdminResource extends ApiRequestContext
with Logging {
"get the list of all active operations")
Review Comment:
Please update the API description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
