pan3793 commented on code in PR #4625:
URL: https://github.com/apache/kyuubi/pull/4625#discussion_r1152717945
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1171,6 +1171,24 @@ object KyuubiConf {
.booleanConf
.createWithDefault(false)
+ val KUBERNETES_INFORMER_PERIOD: ConfigEntry[Long] =
+ buildConf("kyuubi.kubernetes.informer.period")
+ .doc("Kubernetes Informer poll driver pod period." +
+ "Set too small can lead to, stress on Kubernetes Api Server; " +
+ "Set too lager can lead to, app info can't updated in time ")
+ .version("1.8.0")
+ .timeConf
+ .checkValue(_ > 0, "must be positive number")
Review Comment:
```suggestion
.checkValue(_ >= 0, "Invalid resync period provided, It should be a
non-negative value")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
