Karsonnel commented on PR #4661: URL: https://github.com/apache/kyuubi/pull/4661#issuecomment-1495495512
> > > Let's change the name of test from `[KYUUBI #4658] INSERT OVERWRITE DIRECTORY did check query permission` to `INSERT OVERWRITE DIRECTORY`. And add tests for both `InsertIntoDataSourceDirCommand` and `InsertIntoHiveDirCommand` in separate ut? > > > > > > rename test is ok, and i has added tests for both commands in #4660, it's that enough? > > Have noticed 2 ut added in PrivilegesBuilderSuite for different command plan , but only one e2e test added in HiveCatalogRangerSparkExtensionSuite. So it seems only one plan tested in e2e test. Got it, i will add a e2e test for InsertIntoDatasourceDirCommand. thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
