pan3793 commented on code in PR #4689:
URL: https://github.com/apache/kyuubi/pull/4689#discussion_r1162370163
##########
kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/zookeeper/ZookeeperClientProvider.scala:
##########
@@ -26,7 +26,7 @@ import com.google.common.annotations.VisibleForTesting
import org.apache.curator.framework.{CuratorFramework, CuratorFrameworkFactory}
import org.apache.curator.retry._
import org.apache.hadoop.security.UserGroupInformation
-import
org.apache.hadoop.security.token.delegation.ZKDelegationTokenSecretManager.JaasConfiguration
+import org.apache.hadoop.security.authentication.util.JaasConfiguration
Review Comment:
this simple way is acceptable if CI passes, but we'd better make it
compatible w/ the old version as well since users may maintain the internal
Hadoop version which is generally not the latest one.
(Optional) @huapan123456 You can use `DynClasses` `DynConstructors` to
dynamically construct the right class at runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
