felixzh2020 commented on code in PR #4701:
URL: https://github.com/apache/kyuubi/pull/4701#discussion_r1166360491
##########
externals/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/operation/ExecuteStatement.scala:
##########
@@ -115,16 +115,16 @@ class ExecuteStatement(
while (loop) {
Thread.sleep(50) // slow the processing down
- val pageSize = Math.min(500, resultMaxRows)
- val result = executor.snapshotResult(sessionId, resultId, pageSize)
+ val result = executor.snapshotResult(sessionId, resultId,
resultMaxRows)
Review Comment:
In my opinion, if in order to retrieve the result in small pages to avoid
OOM, suggest kyuubi start to check kyuubi.session.engine.flink.max.rows value
and provide detailed explanations on the official website.
Now val pageSize = Math.min(500, resultMaxRows), dead value(500) is
imperfect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
