packyan commented on PR #4716: URL: https://github.com/apache/kyuubi/pull/4716#issuecomment-1511052962
> Alright, but is there any clue why we have to change the name of the plan in the generator rather than just change the generated files? > > In my case, when I was developing function privileges build feature, I needed to use the generator to regenerate spec json files. I trusted the results generated by the generator without checking whether the json had been manually modified. This caused my pr to fail in CI. Although directly modifying the generated json has no effect on users, it is not friendly to developers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
