zwangsheng commented on code in PR #4740:
URL: https://github.com/apache/kyuubi/pull/4740#discussion_r1172324551
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala:
##########
@@ -355,9 +355,15 @@ private[v1] class AdminResource extends ApiRequestContext
with Logging {
private def getEngineSpace(engine: Engine): String = {
val serverSpace = fe.getConf.get(HA_NAMESPACE)
+ val owner = if (engine.getSharelevel == "GROUP") {
Review Comment:
Reference `EngineRef`, using the scala syntax
```
engine.getSharelevel match {
case XXX =>
// do something
case _ =>
// do something
}
```
##########
.gitignore:
##########
@@ -32,6 +32,8 @@
.ensime_lucene
.generated-mima*
.vscode/
+.bloop/
Review Comment:
Please not introduce extraneous changes
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala:
##########
@@ -355,9 +355,15 @@ private[v1] class AdminResource extends ApiRequestContext
with Logging {
private def getEngineSpace(engine: Engine): String = {
val serverSpace = fe.getConf.get(HA_NAMESPACE)
+ val owner = if (engine.getSharelevel == "GROUP") {
Review Comment:
owner => appUser
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
