pan3793 commented on code in PR #4733:
URL: https://github.com/apache/kyuubi/pull/4733#discussion_r1172378308
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/events/ServerEventHandlerRegister.scala:
##########
@@ -36,6 +38,17 @@ object ServerEventHandlerRegister extends
EventHandlerRegister {
kyuubiConf)
}
+ override def createKafkaEventHandler(kyuubiConf: KyuubiConf):
EventHandler[KyuubiEvent] = {
+ val topic: String = kyuubiConf.get(SERVER_EVENT_KAFKA_TOPIC).getOrElse({
+ throw new IllegalArgumentException(s"${SERVER_EVENT_KAFKA_TOPIC.key}
must be configured")
+ })
Review Comment:
Eliminate unnecessary `()`
```suggestion
val topic: String = kyuubiConf.get(SERVER_EVENT_KAFKA_TOPIC).getOrElse {
throw new IllegalArgumentException(s"${SERVER_EVENT_KAFKA_TOPIC.key}
must be configured")
}
```
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/events/ServerEventHandlerRegister.scala:
##########
@@ -36,6 +38,17 @@ object ServerEventHandlerRegister extends
EventHandlerRegister {
kyuubiConf)
}
+ override def createKafkaEventHandler(kyuubiConf: KyuubiConf):
EventHandler[KyuubiEvent] = {
+ val topic: String = kyuubiConf.get(SERVER_EVENT_KAFKA_TOPIC).getOrElse({
+ throw new IllegalArgumentException(s"${SERVER_EVENT_KAFKA_TOPIC.key}
must be configured")
+ })
+ val producerConf = new Properties()
+ kyuubiConf.getAllWithPrefix(KAFKA_SERVER_EVENT_HANDLER_PREFIX,
"").foreach({
+ case (k, v) => producerConf.setProperty(k, v)
+ })
Review Comment:
ditto, for `()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
