bowenliang123 commented on code in PR #4771:
URL: https://github.com/apache/kyuubi/pull/4771#discussion_r1176294937
##########
kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/AdminResourceSuite.scala:
##########
@@ -32,12 +32,16 @@ import org.apache.kyuubi.ha.HighAvailabilityConf
import org.apache.kyuubi.ha.client.DiscoveryClientProvider.withDiscoveryClient
import org.apache.kyuubi.ha.client.DiscoveryPaths
import org.apache.kyuubi.plugin.PluginLoader
+import org.apache.kyuubi.server.KyuubiRestFrontendService
import
org.apache.kyuubi.server.http.authentication.AuthenticationHandler.AUTHORIZATION_HEADER
class AdminResourceSuite extends KyuubiFunSuite with RestFrontendTestHelper {
private val engineMgr = new KyuubiApplicationManager()
+ val encodeAuthorization =
+ new String(Base64.getEncoder.encode(s"${Utils.currentUser}:".getBytes()),
"UTF-8")
Review Comment:
```suggestion
new
String(Base64.getEncoder.encode(s"${Utils.currentUser}:".getBytes()),
StandardCharsets.UTF_8)
```
Prevent magic value, as as the same way in master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
