pan3793 commented on code in PR #4782:
URL: https://github.com/apache/kyuubi/pull/4782#discussion_r1182256294


##########
docs/deployment/engine_on_yarn.md:
##########
@@ -127,13 +127,58 @@ When you want to deploy Kyuubi's Flink SQL engines on 
YARN, you'd better have co
 - An active Object Storage cluster, e.g. 
[HDFS](https://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/HdfsDesign.html),
 S3 and [Minio](https://min.io/) etc.
 - Setup Hadoop client configurations at the machine the Kyuubi server locates
 
-### Yarn Session Mode
+### Flink Deployment Modes
+
+Currently, Flink supports two deployment modes on YARN: [YARN Application 
Mode](https://nightlies.apache.org/flink/flink-docs-release-1.17/docs/deployment/resource-providers/yarn/#application-mode)
 and [YARN Session 
Mode](https://nightlies.apache.org/flink/flink-docs-release-1.17/docs/deployment/resource-providers/yarn/#application-mode).
+
+- YARN Application Mode: In this mode, Kyuubi starts a dedicated Flink 
application cluster and runs the SQL engine on it.
+- YARN Session Mode: In this mode, Kyuubi starts the Flink SQL engine locally 
and connects to a running Flink YARN session cluster.
+
+As Kyuubi has to know the deployment mode before starting the SQL engine, it's 
required to specify the deployment mode in Kyuubi configuration.
+
+```bash
+flink.execution.target: yarn-application # or `yarn-session`
+```

Review Comment:
   kyuubi uses `properties` format, so here should be 
   
   ```properties
   # candidates: yarn-application, yarn-session
   flink.execution.target=yarn-application
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to