pan3793 commented on code in PR #4787:
URL: https://github.com/apache/kyuubi/pull/4787#discussion_r1185649427


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSession.scala:
##########
@@ -49,6 +49,7 @@ abstract class KyuubiSession(
       f
     } catch {
       case t: Throwable =>
+        error(s"Handling $user session[$handle] exception:", t)

Review Comment:
   for exceptions that will be re-thrown, seems not need to print stacktrace 
here



##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSession.scala:
##########
@@ -49,6 +49,7 @@ abstract class KyuubiSession(
       f
     } catch {
       case t: Throwable =>
+        error(s"Handling $user session[$handle] exception:", t)

Review Comment:
   for exceptions that will be re-thrown, seems no need to print stacktrace here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to