pan3793 commented on code in PR #4798:
URL: https://github.com/apache/kyuubi/pull/4798#discussion_r1186656755
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/BatchJobSubmission.scala:
##########
@@ -187,27 +179,24 @@ class BatchJobSubmission(
override protected def runInternal(): Unit = session.handleSessionException {
val asyncOperation: Runnable = () => {
try {
- if (recoveryMetadata.exists(_.peerInstanceClosed)) {
- setState(OperationState.CANCELED)
- } else {
- // If it is in recovery mode, only re-submit batch job if previous
state is PENDING and
- // fail to fetch the status including appId from resource manager.
Otherwise, monitor the
- // submitted batch application.
- recoveryMetadata.map { metadata =>
- if (metadata.state == OperationState.PENDING.toString) {
- _applicationInfo = currentApplicationInfo()
- applicationId(_applicationInfo) match {
- case Some(appId) => monitorBatchJob(appId)
- case None => submitAndMonitorBatchJob()
- }
- } else {
- monitorBatchJob(metadata.engineId)
+ recoveryMetadata match {
Review Comment:
pure refactor, no logic change here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
