bowenliang123 commented on code in PR #4879:
URL: https://github.com/apache/kyuubi/pull/4879#discussion_r1204173748
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/shim/CatalogShim_v3_0.scala:
##########
@@ -35,9 +36,8 @@ class CatalogShim_v3_0 extends CatalogShim_v2_4 {
val defaultCatalog = catalogMgr.currentCatalog
val defaults = Seq(sessionCatalog, defaultCatalog).distinct
- .map(invoke(_, "name").asInstanceOf[String])
- val catalogs = getField(catalogMgr, "catalogs")
- .asInstanceOf[scala.collection.Map[String, _]]
Review Comment:
Did you suggest reverting all changes in `CatalogShim_v3_0` and
`SparkCatalogShim`, leaving it to be deleted soon?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
