pan3793 commented on code in PR #4886:
URL: https://github.com/apache/kyuubi/pull/4886#discussion_r1206177585
##########
externals/kyuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/dialect/JdbcDialect.scala:
##########
@@ -65,6 +65,8 @@ abstract class JdbcDialect extends SupportServiceLoader with
Logging {
def getSchemaHelper(): SchemaHelper
+ def initializationSQLs(): Seq[String]
Review Comment:
why not give it a default implement `SELECT 1`? then we don't need to
overwrite it in each derived classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
