bowenliang123 commented on code in PR #4903:
URL: https://github.com/apache/kyuubi/pull/4903#discussion_r1209977342
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/util/ObjectFilterPlaceHolder.scala:
##########
@@ -18,9 +18,13 @@
package org.apache.kyuubi.plugin.spark.authz.util
import org.apache.spark.sql.catalyst.expressions.Attribute
-import org.apache.spark.sql.catalyst.plans.logical.{LeafNode, LogicalPlan,
Statistics}
+import org.apache.spark.sql.catalyst.plans.logical.{LogicalPlan, UnaryNode}
+
+case class ObjectFilterPlaceHolder(child: LogicalPlan) extends UnaryNode
+ with WithInternalChild {
-case class ObjectFilterPlaceHolder(child: LogicalPlan) extends LeafNode {
override def output: Seq[Attribute] = child.output
- override def computeStats(): Statistics = child.stats
+
+ override def withNewChildInternal(newChild: LogicalPlan): LogicalPlan =
+ this
Review Comment:
```suggestion
override def withNewChildInternal(newChild: LogicalPlan): LogicalPlan =
this
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
