zhouyifan279 opened a new issue, #4934:
URL: https://github.com/apache/kyuubi/issues/4934

   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the 
[issues](https://github.com/apache/kyuubi/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Describe the bug
   
   When FinalStageResourceManager chooses executors to be killed, it may add 
dead executors to the kill list.
   This will leave more than target num of executors survived and cause 
resource waste.
   
   ### Affects Version(s)
   
   master
   
   ### Kyuubi Server Log Output
   
   _No response_
   
   ### Kyuubi Engine Log Output
   
   _No response_
   
   ### Kyuubi Server Configurations
   
   _No response_
   
   ### Kyuubi Engine Configurations
   
   ```yaml
   2023-06-07 06:15:43 CST FinalStageResourceManager INFO - Request to kill 
executors, total count 415, [2580, 2410, 2195, 1570, 2527, 2526, 1830, 1595, 
1938, 1586, 2489, 2975, 2525, 1655, 1541, 2679, 2380, 1905, 2837, 2669, 1742, 
1520, 2558, 2462, 2239, 2425, 1842, 2480, 1984, 1756, 1831, 1808, 1593, 1743, 
2953, 2708, 2106, 2047, 1902, 2341, 2934, 1637, 2223, 2641, 1941, 2148, 2185, 
2447, 2393, 2561, 2855, 2533, 2286, 2759, 2242, 1844, 1883, 2530, 1558, 2027, 
2543, 2176, 1898, 1514, 2935, 2305, 1741, 1857, 2798, 2338, 1797, 2468, 1525, 
2319, 2499, 1849, 1587, 2606, 2645, 2386, 1670, 1645, 2875, 2247, 1843, 2547, 
2531, 1777, 2298, 2727, 2297, 2042, 1663, 2660, 1885, 1823, 1509, 2095, 2592, 
2518, 2439, 1988, 1967, 2601, 2751, 2494, 2085, 2486, 2714, 2465, 2193, 2404, 
2618, 2904, 2165, 2037, 2626, 2265, 1774, 2186, 2177, 2817, 2289, 1530, 1643, 
1504, 1858, 2520, 1841, 2368, 1863, 2204, 2748, 2879, 2445, 1560, 1736, 2200, 
2841, 1861, 2124, 2342, 2551, 2019, 2917, 2877, 2316, 2806, 2712,
  2793, 2492, 1889, 2236, 1714, 2680, 2169, 2911, 1539, 2939, 1816, 1693, 1644, 
1926, 2463, 2383, 2334, 1727, 2288, 1868, 2824, 1744, 2355, 2915, 1948, 2882, 
2035, 2571, 2320, 2777, 2369, 1978, 2458, 1518, 2621, 2151, 2778, 2819, 1711, 
2755, 111, 2956, 1566, 1936, 2139, 1912, 2968, 2931, 2399, 2976, 2109, 2631, 
1510, 2870, 2451, 2582, 1890, 1789, 2500, 2555, 1897, 2146, 1852, 2699, 2138, 
2307, 2091, 1598, 2179, 2568, 1591, 2722, 2945, 2343, 2036, 1829, 2129, 1985, 
1619, 2208, 2050, 1522, 2306, 2979, 1622, 2043, 1933, 2459, 2318, 1964, 2791, 
1846, 2949, 2290, 2726, 1613, 1946, 1673, 1847, 2815, 2858, 2783, 1780, 2838, 
1920, 2762, 2213, 2219, 978, 2754, 2570, 2323, 2957, 2105, 2981, 1718, 2944, 
2018, 2143, 2192, 2438, 2060, 1534, 2732, 1995, 2366, 2448, 2573, 2897, 1488, 
1944, 1874, 2665, 2971, 1524, 2483, 1528, 2100, 745, 1785, 2346, 2587, 1766, 
2082, 1822, 1851, 2535, 2743, 2593, 2126, 1975, 2155, 2473, 1609, 2586, 2928, 
2128, 2025, 1806, 2596, 2015, 1772, 2648, 2205, 2088, 2460, 276
 0, 1881, 2328, 2001, 1716, 2485, 1970, 2295, 2013, 2080, 1697, 2532, 2905, 
1906, 2761, 1845, 2529, 1916, 1571, 2825, 2908, 2222, 2705, 2016, 1625, 1918, 
1983, 2848, 2194, 2605, 2069, 2094, 2538, 2655, 1708, 2187, 2978, 1817, 1631, 
2017, 2876, 2690, 2267, 2970, 2625, 2344, 1762, 2449, 2867, 2491, 1973, 1811, 
279
   2, 2453, 2296, 1604, 1798, 2888, 2756, 2116, 2677, 1958, 2053, 2556, 2688, 
2275, 1589, 2651, 1676, 1710, 2627, 2221, 2782, 1991, 2345, 2010, 2608, 2960, 
2115, 2670, 2084, 2000, 2528, 2363, 229
   3, 2467, 2454, 2964, 2255, 2385, 2333, 1607, 1748, 2354, 2237, 2064, 2711, 
1807, 2511, 1529].
   2023-06-07 06:15:43 CST YarnClusterSchedulerBackend INFO - Requesting to 
kill executor(s) 2580, 2410, 2195, 1570, 2527, 2526, 1830, 1595, 1938, 1586, 
2489, 2975, 2525, 1655, 1541, 2679, 2380,
   1905, 2837, 2669, 1742, 1520, 2558, 2462, 2239, 2425, 1842, 2480, 1984, 
1756, 1831, 1808, 1593, 1743, 2953, 2708, 2106, 2047, 1902, 2341, 2934, 1637, 
2223, 2641, 1941, 2148, 2185, 2447, 2393,
   2561, 2855, 2533, 2286, 2759, 2242, 1844, 1883, 2530, 1558, 2027, 2543, 
2176, 1898, 1514, 2935, 2305, 1741, 1857, 2798, 2338, 1797, 2468, 1525, 2319, 
2499, 1849, 1587, 2606, 2645, 2386, 1670,
   1645, 2875, 2247, 1843, 2547, 2531, 1777, 2298, 2727, 2297, 2042, 1663, 
2660, 1885, 1823, 1509, 2095, 2592, 2518, 2439, 1988, 1967, 2601, 2751, 2494, 
2085, 2486, 2714, 2465, 2193, 2404, 2618,
   2904, 2165, 2037, 2626, 2265, 1774, 2186, 2177, 2817, 2289, 1530, 1643, 
1504, 1858, 2520, 1841, 2368, 1863, 2204, 2748, 2879, 2445, 1560, 1736, 2200, 
2841, 1861, 2124, 2342, 2551, 2019, 2917,
   2877, 2316, 2806, 2712, 2793, 2492, 1889, 2236, 1714, 2680, 2169, 2911, 
1539, 2939, 1816, 1693, 1644, 1926, 2463, 2383, 2334, 1727, 2288, 1868, 2824, 
1744, 2355, 2915, 1948, 2882, 2035, 2571,
   2320, 2777, 2369, 1978, 2458, 1518, 2621, 2151, 2778, 2819, 1711, 2755, 111, 
2956, 1566, 1936, 2139, 1912, 2968, 2931, 2399, 2976, 2109, 2631, 1510, 2870, 
2451, 2582, 1890, 1789, 2500, 2555, 1
   897, 2146, 1852, 2699, 2138, 2307, 2091, 1598, 2179, 2568, 1591, 2722, 2945, 
2343, 2036, 1829, 2129, 1985, 1619, 2208, 2050, 1522, 2306, 2979, 1622, 2043, 
1933, 2459, 2318, 1964, 2791, 1846, 2
   949, 2290, 2726, 1613, 1946, 1673, 1847, 2815, 2858, 2783, 1780, 2838, 1920, 
2762, 2213, 2219, 978, 2754, 2570, 2323, 2957, 2105, 2981, 1718, 2944, 2018, 
2143, 2192, 2438, 2060, 1534, 2732, 19
   95, 2366, 2448, 2573, 2897, 1488, 1944, 1874, 2665, 2971, 1524, 2483, 1528, 
2100, 745, 1785, 2346, 2587, 1766, 2082, 1822, 1851, 2535, 2743, 2593, 2126, 
1975, 2155, 2473, 1609, 2586, 2928, 212
   8, 2025, 1806, 2596, 2015, 1772, 2648, 2205, 2088, 2460, 2760, 1881, 2328, 
2001, 1716, 2485, 1970, 2295, 2013, 2080, 1697, 2532, 2905, 1906, 2761, 1845, 
2529, 1916, 1571, 2825, 2908, 2222, 270
   5, 2016, 1625, 1918, 1983, 2848, 2194, 2605, 2069, 2094, 2538, 2655, 1708, 
2187, 2978, 1817, 1631, 2017, 2876, 2690, 2267, 2970, 2625, 2344, 1762, 2449, 
2867, 2491, 1973, 1811, 2792, 2453, 229
   6, 1604, 1798, 2888, 2756, 2116, 2677, 1958, 2053, 2556, 2688, 2275, 1589, 
2651, 1676, 1710, 2627, 2221, 2782, 1991, 2345, 2010, 2608, 2960, 2115, 2670, 
2084, 2000, 2528, 2363, 2293, 2467, 245
   4, 2964, 2255, 2385, 2333, 1607, 1748, 2354, 2237, 2064, 2711, 1807, 2511, 
1529
   2023-06-07 06:15:43 CST YarnClusterSchedulerBackend WARN - Executor to kill 
2580 does not exist!
   2023-06-07 06:15:43 CST YarnClusterSchedulerBackend WARN - Executor to kill 
2527 does not exist!
   2023-06-07 06:15:43 CST YarnClusterSchedulerBackend WARN - Executor to kill 
2526 does not exist!
   2023-06-07 06:15:43 CST YarnClusterSchedulerBackend WARN - Executor to kill 
1595 does not exist!
   2023-06-07 06:15:43 CST YarnClusterSchedulerBackend WARN - Executor to kill 
1938 does not exist!
   2023-06-07 06:15:43 CST YarnClusterSchedulerBackend WARN - Executor to kill 
1586 does not exist!
   2023-06-07 06:15:43 CST YarnClusterSchedulerBackend WARN - Executor to kill 
2489 does not exist!
   2023-06-07 06:15:43 CST YarnClusterSchedulerBackend WARN - Executor to kill 
2525 does not exist!
   2023-06-07 06:15:43 CST YarnClusterSchedulerBackend WARN - Executor to kill 
1541 does not exist!
   2023-06-07 06:15:43 CST YarnClusterSchedulerBackend WARN - Executor to kill 
2679 does not exist!
   2023-06-07 06:15:43 CST YarnClusterSchedulerBackend WARN - Executor to kill 
1905 does not exist!
   ```
   
   
   ### Additional context
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes. I would be willing to submit a PR with guidance from the Kyuubi 
community to fix.
   - [ ] No. I cannot submit a PR at this time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to