cfmcgrady commented on code in PR #4950:
URL: https://github.com/apache/kyuubi/pull/4950#discussion_r1226110834
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStoreConf.scala:
##########
@@ -37,7 +37,9 @@ object JDBCMetadataStoreConf {
val METADATA_STORE_JDBC_DATABASE_TYPE: ConfigEntry[String] =
buildConf("kyuubi.metadata.store.jdbc.database.type")
.doc("The database type for server jdbc metadata store.<ul>" +
- " <li>DERBY: Apache Derby, JDBC driver
`org.apache.derby.jdbc.AutoloadedDriver`.</li>" +
+ " <li>(Deprecated) DERBY: Apache Derby, JDBC driver " +
+ "`org.apache.derby.jdbc.AutoloadedDriver`.</li>" +
+ " <li>SQLITE: SQLite3, JDBC driver `org.sqlite.JDBC`.</li>" +
Review Comment:
shall we make a note in the documentation to indicate that the support for
SQLite is available starting from version 1.8.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
