turboFei commented on code in PR #4962:
URL: https://github.com/apache/kyuubi/pull/4962#discussion_r1229457446
##########
kyuubi-hive-beeline/src/main/java/org/apache/hive/beeline/KyuubiBeeLine.java:
##########
@@ -189,4 +199,53 @@ int initArgs(String[] args) {
}
return code;
}
+
+ // see HIVE-19048 : Initscript errors are ignored
+ @Override
+ int runInit() {
+ String[] initFiles = getOpts().getInitFiles();
+
+ // executionResult will be ERRNO_OK only if all initFiles execute
successfully
+ int executionResult = ERRNO_OK;
+ boolean exitOnError = !getOpts().getForce();
+ DynFields.BoundField<Boolean> exitField = null;
+
+ if (initFiles != null && initFiles.length != 0) {
+ for (String initFile : initFiles) {
+ info("Running init script " + initFile);
+ try {
+ int currentResult;
+ try {
+ currentResult =
+ DynMethods.builder("executeFile")
+ .hiddenImpl(BeeLine.class, String.class)
+ .buildChecked(this)
+ .invoke(initFile);
+ exitField = DynFields.builder().hiddenImpl(BeeLine.class,
"exit").buildChecked(this);
+ } catch (Exception t) {
+ error(t.getMessage());
+ currentResult = ERRNO_OTHER;
+ }
+
+ if (currentResult != ERRNO_OK) {
+ executionResult = currentResult;
+
+ if (exitOnError) {
+ return executionResult;
+ }
+ }
+ } finally {
+ // exit beeline if there is initScript failure and --force is not set
+ boolean exit = exitOnError && executionResult != ERRNO_OK;
+ try {
+ exitField.set(exit);
+ } catch (Exception t) {
+ error(t.getMessage());
+ return ERRNO_OTHER;
+ }
+ }
+ }
+ }
+ return executionResult;
+ }
Review Comment:
The code in hive-3.1.3.
<img width="1167" alt="image"
src="https://github.com/apache/kyuubi/assets/6757692/19b803b1-f3eb-4a65-820b-9960d7b98399";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
