bowenliang123 commented on code in PR #4970:
URL: https://github.com/apache/kyuubi/pull/4970#discussion_r1231810829
##########
kyuubi-util-scala/src/main/scala/org/apache/kyuubi/util/reflect/ReflectUtils.scala:
##########
@@ -70,20 +78,26 @@ object ReflectUtils {
* @return
*/
def invokeAs[T](target: AnyRef, methodName: String, args: (Class[_],
AnyRef)*): T = {
- val targetClass = target.getClass
+ val (clz, obj) = getTargetClass(target)
val argClasses = args.map(_._1)
try {
- DynMethods.builder(methodName)
- .hiddenImpl(targetClass, argClasses: _*)
- .buildChecked(target)
- .invoke[T](args.map(_._2): _*)
+ val method = DynMethods.builder(methodName)
+ .hiddenImpl(clz, argClasses: _*)
+ .impl(clz, argClasses: _*)
+ .buildChecked
+ if (method.isStatic) {
+ method.asStatic.invoke[T](args.map(_._2): _*)
Review Comment:
After my second thought, a dedicated method for static class may cause
confusion for usage, eg. a method of Sacla object class is not static. The
usages for both object/static class and common classes are shown in test cases
which clear enough to understand and use. I would keep it as it is with auto
detecting for whether it's a static one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
