link3280 commented on issue #4806: URL: https://github.com/apache/kyuubi/issues/4806#issuecomment-1605299330
The difference is that in Spark scenarios the result is always ready and complete, so the client would know the result rows are fully fetched if one fetch is empty. That's to say, `TFetchResultsResp.hasMoreRows` is not required (and it's not used actually, see the codes below). https://github.com/apache/kyuubi/blob/056c5efbe404a42c0993176dfd95da3e8cf4619e/kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiQueryResultSet.java#L333-L348 However, in Flink scenarios, the result could be temporarily empty because the result data is not ready. That means we need a clear sign of EOS, which could be `TFetchResultsResp.hasMoreRows`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
