risyomei commented on code in PR #5002:
URL: https://github.com/apache/kyuubi/pull/5002#discussion_r1244575706
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkSQLEngine.scala:
##########
@@ -147,6 +162,34 @@ case class SparkSQLEngine(spark: SparkSession) extends
Serverable("SparkSQLEngin
TimeUnit.MILLISECONDS)
}
}
+
+ private[kyuubi] def startFailFastChecker(stop: () => Unit): Unit = {
+ val interval = conf.get(ENGINE_CHECK_INTERVAL)
Review Comment:
Still using the `ENGINE_CHECK_INTERVAL`, but I am open to add a new
configuration key
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkSQLEngine.scala:
##########
@@ -147,6 +162,34 @@ case class SparkSQLEngine(spark: SparkSession) extends
Serverable("SparkSQLEngin
TimeUnit.MILLISECONDS)
}
}
+
+ private[kyuubi] def startFailFastChecker(stop: () => Unit): Unit = {
+ val interval = conf.get(ENGINE_CHECK_INTERVAL)
+ val deregistered = new AtomicBoolean(false)
+ var timeout = Duration(60, TimeUnit.SECONDS).toMillis
Review Comment:
Using a fixed duration 60 seconds, but I am open to add a new configuration
key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
