wForget commented on code in PR #4932:
URL: https://github.com/apache/kyuubi/pull/4932#discussion_r1246416570
##########
extensions/spark/kyuubi-spark-lineage/src/main/scala/org/apache/kyuubi/plugin/lineage/dispatcher/atlas/AtlasEntityHelper.scala:
##########
@@ -104,33 +104,38 @@ object AtlasEntityHelper {
}
def tableObjectId(tableName: String): Option[AtlasObjectId] = {
- val dbTb = tableName.split('.')
- if (dbTb.length == 2) {
- val qualifiedName = tableQualifiedName(cluster, dbTb(0), dbTb(1))
- // TODO parse datasource type
- Some(new AtlasObjectId(HIVE_TABLE_TYPE, "qualifiedName", qualifiedName))
- } else {
- None
+ tableName.split('.') match {
+ case Array(catalog, db, table) =>
Review Comment:
I think the catalog will only be used to judge the data source type and not
be part of the qualifiedName.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
