risyomei commented on code in PR #5002:
URL: https://github.com/apache/kyuubi/pull/5002#discussion_r1248813471
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1282,6 +1282,15 @@ object KyuubiConf {
.timeConf
.createWithDefault(0)
+ val ENGINE_SPARK_MAX_INITIAL_WAIT: ConfigEntry[Long] =
+ buildConf("kyuubi.session.engine.spark.max.initial.wait")
+ .doc("Max wait time for the initial connection to Spark engine. The
engine will" +
+ " self-terminate no new incoming connection is established within this
time." +
+ "This setting only applies at the CONNECTION share level.")
+ .version("1.8.0")
+ .timeConf
+ .createWithDefault(Duration.ofSeconds(0).toMillis)
Review Comment:
~The reason I disabled this feature because it seems to affect the CI/CD
test.
As I described in
https://github.com/apache/kyuubi/pull/5002#issuecomment-1611305696, almost
every test are failing. But they runs fine locally.~
~Do you have any idea how I can improve it?~
I have slightly modified the existing tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
