ulysses-you commented on code in PR #5023:
URL: https://github.com/apache/kyuubi/pull/5023#discussion_r1253841677
##########
extensions/spark/kyuubi-spark-connector-hive/src/main/scala/org/apache/kyuubi/spark/connector/hive/HiveTableCatalog.scala:
##########
@@ -103,6 +103,7 @@ class HiveTableCatalog(sparkSession: SparkSession)
s"Require setting ${CATALOG_IMPLEMENTATION.key} to `hive` to enable hive
support.")
catalogName = name
catalogOptions = options
+ sessionState.conf.setConfString("spark.sql.legacy.v1IdentifierNoCatalog",
"true")
Review Comment:
to be conservative, can we wrap all session catalog methods with:
```
withSQLConf("spark.sql.legacy.v1IdentifierNoCatalog" -> "true") {
...
}
```
I'm afraid it would affect session catalog behavior if people use both
kyuubi hive catalog and vanilla spark session catalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
