zwangsheng commented on code in PR #5062:
URL: https://github.com/apache/kyuubi/pull/5062#discussion_r1267770070
##########
charts/kyuubi/templates/kyuubi-service.yaml:
##########
@@ -15,6 +15,23 @@
limitations under the License.
*/}}
+apiVersion: v1
+kind: Service
+metadata:
+ name: {{ $.Release.Name }}-headless
+ labels:
+ {{- include "kyuubi.labels" $ | nindent 4 }}
+spec:
+ type: ClusterIP
Review Comment:
we should add `clusterIp: None` here, as kubernetes doc said:
> In this case, you can create what are termed headless Services, by
explicitly specifying "None" for the cluster IP address (.spec.clusterIP).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
