bowenliang123 commented on code in PR #5055: URL: https://github.com/apache/kyuubi/pull/5055#discussion_r1271619831
########## extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/serde/Function.scala: ########## @@ -22,7 +22,8 @@ package org.apache.kyuubi.plugin.spark.authz.serde * * Represents a function identity * - * @param database * @param functionName + * @param database + * @param catalog */ -case class Function(database: Option[String], functionName: String) +case class Function(functionName: String, database: Option[String], catalog: Option[String]) Review Comment: According to other identity types like `Table` and `Database`, it's preferred adding `catalog` in the first place to follow the same pattern in `catalog - db/namespace - object` style. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
