pan3793 commented on code in PR #5097:
URL: https://github.com/apache/kyuubi/pull/5097#discussion_r1277053249
##########
docs/deployment/settings.md:
##########
@@ -419,7 +419,7 @@ You can configure the Kyuubi properties in
`$KYUUBI_HOME/conf/kyuubi-defaults.co
| kyuubi.session.engine.spark.progress.timeFormat | yyyy-MM-dd
HH:mm:ss.SSS | The time format of the progress bar
| string | 1.6.0 |
| kyuubi.session.engine.spark.progress.update.interval | PT1S
| Update period of progress bar.
| duration | 1.6.0 |
| kyuubi.session.engine.spark.showProgress | false
| When true, show the progress bar in the Spark's engine log.
| boolean | 1.6.0 |
-| kyuubi.session.engine.startup.destroy.timeout | PT5S
| Engine startup process destroy wait time, if the process does not stop
after this time, force destroy instead. This configuration only takes effect
when `kyuubi.session.engine.startup.waitCompletion=false`.
| duration | 1.8.0 |
+| kyuubi.session.engine.startup.destroy.timeout | PT5S
| Engine startup process destroy wait time, if the process does not stop
after this time, force destroy instead. This configuration only takes effect
when `kyuubi.session.engine.startup.waitCompletion=false`.
| duration | 1.7.2 |
Review Comment:
```suggestion
| kyuubi.session.engine.startup.destroy.timeout | PT5S
| Engine startup process destroy wait time, if the process does not stop
after this time, force destroy instead. This configuration only takes effect
when `kyuubi.session.engine.startup.waitCompletion=false`.
| duration | 1.8.0 |
```
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1518,7 +1518,7 @@ object KyuubiConf {
.doc("Engine startup process destroy wait time, if the process does not
" +
"stop after this time, force destroy instead. This configuration only
" +
s"takes effect when
`${SESSION_ENGINE_STARTUP_WAIT_COMPLETION.key}=false`.")
- .version("1.8.0")
+ .version("1.7.2")
Review Comment:
```suggestion
.version("1.8.0")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
