pan3793 commented on code in PR #4790:
URL: https://github.com/apache/kyuubi/pull/4790#discussion_r1278841611


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/BatchesResource.scala:
##########
@@ -58,6 +58,10 @@ private[v1] class BatchesResource extends ApiRequestContext 
with Logging {
   private lazy val internalConnectTimeout =
     fe.getConf.get(BATCH_INTERNAL_REST_CLIENT_CONNECT_TIMEOUT).toInt
 
+  private def batchV2Enabled(reqConf: Map[String, String]): Boolean = {
+    reqConf.getOrElse(BATCH_API_VERSION.key, 
fe.getConf.get(BATCH_API_VERSION)) == "2"

Review Comment:
   > so, in server side, the batch v2 is always supported?
   
   No, now. But should be right in the future.
   
   I suppose `kyuubi.batch.submitter.enabled` will be removed in the future, 
and always be enabled when the REST frontend is enabled.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to