bowenliang123 commented on code in PR #5149:
URL: https://github.com/apache/kyuubi/pull/5149#discussion_r1288395551
##########
kyuubi-util-scala/src/main/scala/org/apache/kyuubi/util/reflect/ReflectUtils.scala:
##########
@@ -93,11 +93,13 @@ object ReflectUtils {
} catch {
case e: Exception =>
val candidates =
- (clz.getDeclaredMethods ++
clz.getMethods).map(_.getName).distinct.sorted
- val argClassesNames = argClasses.map(_.getClass.getName)
+ (clz.getDeclaredMethods ++ clz.getMethods)
+ .map(m =>
s"${m.getName}(${m.getParameterTypes.map(_.getName).mkString(", ")})")
Review Comment:
```suggestion
.map(m =>
s"${m.getName}(${m.getParameterTypes.map(_.getSimpleName).mkString(", ")})")
```
A simple class name should be good enough for debugging. Full class name for
common classes (other than primitive types) is too long for multiple params of
all methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
