pan3793 commented on code in PR #5158:
URL: https://github.com/apache/kyuubi/pull/5158#discussion_r1294125974
##########
kyuubi-zookeeper/src/main/scala/org/apache/kyuubi/zookeeper/ZookeeperConf.scala:
##########
@@ -49,6 +49,13 @@ object ZookeeperConf {
.stringConf
.createOptional
+ val ZK_CLIENT_USE_HOSTNAME: ConfigEntry[Boolean] =
+ buildConf("kyuubi.zookeeper.embedded.client.use.hostname")
+ .doc("When true, embedded Zookeeper prefer to bind hostname, otherwise,
ip address.")
+ .version("1.7.2")
+ .booleanConf
+ .createWithDefault(false)
Review Comment:
yea, was thought that, but since it's not for production, I think behavior
change should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
