bowenliang123 commented on code in PR #5134:
URL: https://github.com/apache/kyuubi/pull/5134#discussion_r1296052481
##########
externals/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/operation/FlinkOperation.scala:
##########
@@ -98,25 +105,43 @@ abstract class FlinkOperation(session: Session) extends
AbstractOperation(sessio
assertState(OperationState.FINISHED)
setHasResultSet(true)
order match {
- case FETCH_NEXT => resultSet.getData.fetchNext()
+ case FETCH_NEXT =>
Review Comment:
Is it changed to doing nothing for `FETCH_NEXT` ?
Move to the last condition if it's necessary. Or it is misleading a fallback
situation
(or use `case FETCH_NEXT | FETCH_PRIOR` for falling back)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
